[ https://issues.apache.org/jira/browse/LUCENE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770852#action_12770852 ]
Shai Erera commented on LUCENE-1994: ------------------------------------ Mike, reuseFields is now used only in this line: {code} final Document doc = reuseFields ? ds.doc : new Document(); {code} Shouldn't Document also be per-thread (i.e., ThreadLocal), same as DocState? Otherwise, if reuse.fields = true, the same Document object will be shared by multiple threads, right? Also, getDocState() now passes reuseFields = true to DocState always, and I think it should pass reuseFields itself. Since before if reuseFields was false, localDocState was used. > EnwikiConentSource does not work with parallel tasks > ---------------------------------------------------- > > Key: LUCENE-1994 > URL: https://issues.apache.org/jira/browse/LUCENE-1994 > Project: Lucene - Java > Issue Type: Bug > Components: contrib/benchmark > Affects Versions: 2.9 > Reporter: Mark Miller > Assignee: Michael McCandless > Priority: Minor > Fix For: 3.0 > > Attachments: LUCENE-1994.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org