[
https://issues.apache.org/jira/browse/LUCENE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771496#action_12771496
]
Cédrik LIME commented on LUCENE-2015:
-------------------------------------
Robert,
All I did is refactor the big switch(c) into its own method:
public static final int foldToASCII(char c, char[] output, int outputPos)
and change the caller (public void foldToASCII(char[] input, int length))
accordingly.
I can submit a patch without formatting changes, but that means the source
won't be nicely indented...
Please advise.
As for the ISOLatin1AccentFilter patch, it really is to enable us to remove a
workaround for an issue we had with some special (yet frequent) chars. Feel
free to ignore it should you think this part is not relevant.
> ASCIIFoldingFilter: expose folding logic + small improvements to
> ISOLatin1AccentFilter
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-2015
> URL: https://issues.apache.org/jira/browse/LUCENE-2015
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Cédrik LIME
> Priority: Minor
> Attachments: Filters.patch
>
>
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (namely:
> left & right single quotation marks, en dash, em dash) which we very
> frequently encounter in our projects. I know that this class is now
> deprecated; this improvement is for legacy code that hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in
> ASCIIFoldingFilter for potential re-use in non-Lucene-related code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
