[ 
https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776981#action_12776981
 ] 

Michael McCandless commented on LUCENE-1909:
--------------------------------------------

I sort of agree with Mark, now... the default is "don't subsample the terms 
index", so it is rather odd to make this public.

I think it does make sense to have a private named constant for this (instead 
of "1" all throughout the code) for code readability.

Yet, Lucene does do this "static final public default" constant in a number of 
places.

My guess is this is a Solr need, right?  Ie, Solr is exposing control over 
terms index divisor, and would like to set a default for that param, and so the 
natural thing to do is wire it to Lucene's default.  Outside Solr, it's hard to 
imagine why apps would need to (should) refer to this constant.

> Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public
> ---------------------------------------------------
>
>                 Key: LUCENE-1909
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1909
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Uwe Schindler
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE_1909.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to