[
https://issues.apache.org/jira/browse/LUCENE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778193#action_12778193
]
Robert Muir commented on LUCENE-2051:
-------------------------------------
{quote}
sure, they solve two different things.
static Set<?> getDefaultStopSet() -> will always return the default stopword
set. (replacement for the String array
getStopwords() -> returns the currently used stopwords by the analyzer.
that is all. If we can get rid of that completely I'm fine with it. I would
actually like to not expose the stopwords. We could put them all in files in
3.1 and load them from there?!
{quote}
yeah i too prefer they be hidden behind a method, (we should store them however
we damn well feel, i do like files though)
just wanted to make sure it would not somehow present a problem for
StopAwareAnalyzer in the future, if it can support getting this set then we are
ok.
> Contrib Analyzer Setters should be deprecated and replace with ctor arguments
> -----------------------------------------------------------------------------
>
> Key: LUCENE-2051
> URL: https://issues.apache.org/jira/browse/LUCENE-2051
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Affects Versions: 2.9.1
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-2051.patch, LUCENE-2051.patch
>
>
> Some analyzers in contrib provide setters for stopword / stem exclusion sets
> / hashtables etc. Those setters should be deprecated as they yield unexpected
> behaviour. The way they work is they set the reusable token stream instance
> to null in a thread local cache which only affects the tokenstream in the
> current thread. Analyzers itself should be immutable except of the
> threadlocal.
> will attach a patch soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
