[ https://issues.apache.org/jira/browse/LUCENE-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779690#action_12779690 ]
Simon Willnauer commented on LUCENE-2081: ----------------------------------------- IMO we should start a refactoring beginning with Shape and CartesianPolyFilterBuilder. This needs Documentation, cleanup and optimization. The Shape List<Double> member bugs me in particular - we could save a lot of object creations when we could change this to an array of doubles where Shapes and their arrays could be reused somehow. I have reserved some time to work on spatial in Dec. CartesianPolyFilterBuilder is the place to start from my point of view. > CartesianShapeFilter improvements > --------------------------------- > > Key: LUCENE-2081 > URL: https://issues.apache.org/jira/browse/LUCENE-2081 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/spatial > Affects Versions: 2.9 > Reporter: Grant Ingersoll > Priority: Minor > > The CartesiahShapeFilter could use some improvements. For starters, if we > make sure the boxIds are sorted in index order, this should reduce the cost > of seeks. I think we should also replace the logging with a similar approach > to Lucene's output stream. We also can do Term creation a tad bit more > efficiently too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org