NP, sounds good. Michael
-----Original Message----- From: Mark Miller [mailto:markrmil...@gmail.com] Sent: Thursday, November 19, 2009 5:02 PM To: java-dev@lucene.apache.org Subject: Re: CustomScoreQuery Explanation No worries - I think its a bit overkill for the change - I can just pop it in real quick. Michael Garski wrote: > > Will do, along with a patch. > > > > Michael > > > > *From:* Simon Willnauer [mailto:simon.willna...@googlemail.com] > *Sent:* Thursday, November 19, 2009 4:47 PM > *To:* java-dev@lucene.apache.org > *Subject:* Re: CustomScoreQuery Explanation > > > > I don't see any reason why doExplain should be called twice. Can you > create an issue in jira please? > > Simon > > On Nov 20, 2009 1:30 AM, "Michael Garski" <mgar...@myspace-inc.com > <mailto:mgar...@myspace-inc.com>> wrote: > > Hi there – > > > > I’m helping out with the Lucene.Net port of 2.9, and when rooting > around in CustomScoreQuery.CustomWeight, I noticed what appears to > be an unnecessary call to doExplain in the explain method. > > > > Current method in trunk: > > > > *public* Explanation explain(IndexReader reader, *int* doc) > *throws* IOException { > > Explanation explain = doExplain(reader, doc); > > *return* explain == *null* ? *new* Explanation(0.0f, "no > matching docs") : doExplain(reader, doc); > > } > > > > Is there a reason it shouldn’t be: > > > > *public* Explanation explain(IndexReader reader, *int* doc) > *throws* IOException { > > Explanation explain = doExplain(reader, doc); > > *return* explain == *null* ? *new* Explanation(0.0f, "no > matching docs") : explain); > > } > > > > I might be overlooking something, but it appears to be two calls > to doExplain when only one would suffice. > > > > Michael > > > > Michael Garski > > Sr. Search Architect > > 310.969.7435 (office) > > 310.251.6355 (mobile) > > www.myspace.com/michaelgarski <http://www.myspace.com/michaelgarski> > > > -- - Mark http://www.lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
