[
https://issues.apache.org/jira/browse/LUCENE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783395#action_12783395
]
Robert Muir commented on LUCENE-2094:
-------------------------------------
Hi Simon,
One thing I noticed is with this patch we get:
{code}
public StopFilter(Version matchVersion, boolean enablePositionIncrements,
TokenStream input, Set<?> stopWords, boolean ignoreCase)
{code}
I know this is really not related to what you are doing here, but I wonder if
instead StopFilter should look like this:
{code}
public StopFilter(Version matchVersion, TokenStream input, Set<?> stopWords,
boolean ignoreCase)
{code}
and use matchVersion to determine enablePositionIncrements.
I think its already wierd how to create a stopfilter, you have to pass version
to a static method getEnablePositionIncrementsVersionDefault. I don't think the
user should have to pass Version twice:
{code}
new StopFilter(Version.WHATEVER,
StopFilter.getEnablePositionIncrementsVersionDefault(Version.WHATEVER), ...)
{code}
I guess i think this getEnablePositionIncrementsVersionDefault should be
deprecated along with the ctors that take this boolean argument, and it should
all be driven off a single Version argument for simplicity
> Prepare CharArraySet for Unicode 4.0
> ------------------------------------
>
> Key: LUCENE-2094
> URL: https://issues.apache.org/jira/browse/LUCENE-2094
> Project: Lucene - Java
> Issue Type: Bug
> Components: Analysis
> Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.3.3, 2.4,
> 2.4.1, 2.4.2, 2.9, 2.9.1, 2.9.2, 3.0, 3.0.1, 3.1
> Reporter: Simon Willnauer
> Fix For: 3.1
>
> Attachments: LUCENE-2094.patch, LUCENE-2094.txt, LUCENE-2094.txt,
> LUCENE-2094.txt
>
>
> CharArraySet does lowercaseing if created with the correspondent flag. This
> causes that String / char[] with uncode 4 chars which are in the set can not
> be retrieved in "ignorecase" mode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
