[
https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784328#action_12784328
]
Uwe Schindler edited comment on LUCENE-2034 at 12/1/09 6:49 PM:
----------------------------------------------------------------
{quote}
On a separate note:
In WordListLoader the return types are not Set or Map, but HashSet and HashMap.
What's up with that? Should anyone care what the particular implementation is?
{quote}
That's historical. For 2.9 it was not possible to provide the method covariant
with different return type for BW compatibility, so the old ones could not be
deprecated. With 3.0 they stayed alive and now there they are.
With Java 1.5, there should be the possibility to provide an covariant overload
and deprecate the specializations. I will try out in a separate issue!
Ideally he new methods should return Set<?> but implement this by a
CharArraySet (which would be possible then). At the moment the sets are always
copied to CharArraySet in each Analyzer.
was (Author: thetaphi):
{quote}
On a separate note:
In WordListLoader the return types are not Set or Map, but HashSet and HashMap.
What's up with that? Should anyone care what the particular implementation is?
{quote}
That's historical. For 2.9 it was not possible to provide the method covariant
with different return type for BW compatibility, so the old ones could not be
deprecated. With 3.0 they stayed alive and now there they are.
With Java 1.5, there should be the possibility to provide an covariant overload
and deprecate the specializations. I will try out in a separate issue!
> Massive Code Duplication in Contrib Analyzers - unifly the analyzer ctors
> -------------------------------------------------------------------------
>
> Key: LUCENE-2034
> URL: https://issues.apache.org/jira/browse/LUCENE-2034
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Affects Versions: 2.9
> Reporter: Simon Willnauer
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2034,patch, LUCENE-2034,patch, LUCENE-2034.patch,
> LUCENE-2034.patch, LUCENE-2034.patch, LUCENE-2034.patch, LUCENE-2034.patch,
> LUCENE-2034.txt
>
>
> Due to the variouse tokenStream APIs we had in lucene analyzer subclasses
> need to implement at least one of the methodes returning a tokenStream. When
> you look at the code it appears to be almost identical if both are
> implemented in the same analyzer. Each analyzer defnes the same inner class
> (SavedStreams) which is unnecessary.
> In contrib almost every analyzer uses stopwords and each of them creates his
> own way of loading them or defines a large number of ctors to load stopwords
> from a file, set, arrays etc.. those ctors should be removed / deprecated and
> eventually removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
