[ 
https://issues.apache.org/jira/browse/LUCENE-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785264#action_12785264
 ] 

Robert Muir edited comment on LUCENE-2091 at 12/3/09 10:56 AM:
---------------------------------------------------------------

Hi Yuval, I see your patch, I can help with some relevance testing and comments.

I don't know if it should be assigned to me, maybe we can trick one of the devs 
who really knows the scoring system to well to look at it, especially about 
performance and things like that.

Here is the first thing I noticed, maybe I am completely stupid but I never 
understood this:

I don't understand why we need BM25Boolean.* and everything like that. I don't 
understand why these are necessary, they seem to be duplicates of BooleanQuery 
etc and just sum up subscorers or whatever. 

So in my usages I dropped them. I just have BM25TermQuery,BM25TermScorer, and 
BM25Parameters and to use it, I override a method in QueryParser. 

edit: by the way, I don't want to imply that what I am doing is "best" either, 
because I don't think it is, only that this would be one way to simplify the 
code a lot as a first step.


      was (Author: rcmuir):
    Hi Yuval, I see your patch, I can help with some relevance testing and 
comments.

I don't know if it should be assigned to me, maybe we can trick one of the devs 
who really knows the scoring system to well to look at it, especially about 
performance and things like that.

Here is the first thing I noticed, maybe I am completely stupid but I never 
understood this:

I don't understand why we need BM25Boolean.* and everything like that. I don't 
understand why these are necessary, they seem to be duplicates of BooleanQuery 
etc and just sum up subscorers or whatever. 

So in my usages I dropped them. I just have BM25TermQuery,BM25TermScorer, and 
BM25Parameters and to use it, I override a method in QueryParser. 

  
> Add BM25 Scoring to Lucene
> --------------------------
>
>                 Key: LUCENE-2091
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2091
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: contrib/*
>            Reporter: Yuval Feinstein
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2091.patch, persianlucene.jpg
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> http://nlp.uned.es/~jperezi/Lucene-BM25/ describes an implementation of 
> Okapi-BM25 scoring in the Lucene framework,
> as an alternative to the standard Lucene scoring (which is a version of mixed 
> boolean/TFIDF).
> I have refactored this a bit, added unit tests and improved the runtime 
> somewhat.
> I would like to contribute the code to Lucene under contrib. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to