[ 
https://issues.apache.org/jira/browse/LUCENE-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786515#action_12786515
 ] 

Simon Willnauer commented on LUCENE-2117:
-----------------------------------------

Robert, the patch looks almost good. You should also change the 
pom.xml.template to reflect the new dependency. I'm still thinking about moving 
snowball into analyzers as a analyzers/snowball would that make sense?

Somewhat unrelated but still ugly:
{code}
      Class<?> stemClass = Class.forName("org.tartarus.snowball.ext." + name + 
"Stemmer");
{code}
When I look through the patch I see this "name" parameter which is used to load 
a stemmer per reflection. We should really define a factory interface that 
creates the stemmer and get rid of the refelction code

> Fix SnowballAnalyzer casing behavior for Turkish Language
> ---------------------------------------------------------
>
>                 Key: LUCENE-2117
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2117
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>    Affects Versions: 3.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2117.patch
>
>
> LUCENE-2102 added a new TokenFilter to handle Turkish unique casing behavior 
> correctly. We should fix the casing behavior in SnowballAnalyzer too as it 
> supports a TurkishStemmer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to