[ 
https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788811#action_12788811
 ] 

Uwe Schindler commented on LUCENE-2123:
---------------------------------------

I already closed this issue, but still open is migration to 3.0, where the PQ 
is somehow broken (can consume too much RAM). There are two possibilities to 
merge:

- Apply this patch to 3.0 -> new features, ok for 3.0 branch
- Only fix PQ issue in FuzzyQuery -> Problem: ScoreDoc is protected and there 
is the need to change the comparator (inverse). In my opinion the ScoreTerm 
should be a private class at all (like it is in MTQ now). But we cannot change 
it (BW compatibility). A solution could be to ignore the comparator and give 
the inverse comparator in the PQ ctor as param. In trunk, the ScoreTerm class 
is deprecated and dead code, but has the original comparator.

What to do?

> Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter 
> fails to highlight FuzzyQuery
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2123
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2123
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>    Affects Versions: Flex Branch
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, 
> LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, 
> LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, 
> LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch
>
>
> As FuzzyQuery does not allow to change the rewrite mode, highlighter fails 
> with UOE in flex since LUCENE-2110, because it changes the rewrite mode to 
> Boolean query. The fix is: Allow MTQ to change rewrite method and make 
> FUZZY_REWRITE public for that.
> The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also 
> the code will be refactored to make heavy reuse of term enumeration code and 
> only plug in the PQ for filtering the top terms.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to