[ 
https://issues.apache.org/jira/browse/LUCENE-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788943#action_12788943
 ] 

Michael McCandless commented on LUCENE-2144:
--------------------------------------------

Patch looks good; tests pass.  I'll commit shortly.

The core change is to just make it possible to override isDeleted logic in 
AllTermDocs.

The flex API makes this easier -- you must provided a Bits (new interface),  
specifying the docs you want to skip, when you request the DocsEnum.

We should fix this on at least 3.0 as well right?

> InstantiatedIndexReader does not handle #termDocs(null) correct (AllTermDocs)
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-2144
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2144
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>    Affects Versions: 2.9, 2.9.1, 3.0
>            Reporter: Karl Wettin
>            Assignee: Michael McCandless
>            Priority: Critical
>         Attachments: LUCENE-2144.txt
>
>
> This patch contains core changes so someone else needs to commit it.
> Due to the incompatible #termDocs(null) behaviour at least MatchAllDocsQuery, 
> FieldCacheRangeFilter and ValueSourceQuery fails using II since 2.9.
> AllTermDocs now has a superclass, AbstractAllTermDocs that also 
> InstantiatedAllTermDocs extend.
> Also:
>  * II-tests made less plausable to pass on future incompatible changes to 
> TermDocs and TermEnum
>  * IITermDocs#skipTo and #next mimics the behaviour of document posisioning 
> from SegmentTermDocs#dito when returning false
>  * II now uses BitVector rather than sets for deleted documents

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to