[
https://issues.apache.org/jira/browse/LUCENE-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789326#action_12789326
]
Simon Willnauer commented on LUCENE-2148:
-----------------------------------------
Chris, we have to keep in mind that this code has already been released so we
should not remove all those methods. We should rather go the deprecation way
and mark everything which should go away as deprectaed. I really want to see
those Point etc stuff being immutable but I would feel better if we could mark
them as deprecated and add some comment like @deprected use foo(int) instead.
Futher I would keep the equals and hashcode method just in case somebody uses
them in any datastructure relying on those methods.Remember they could be used
as a cache key in a bounding box or something similar.
simon
> Improve Spatial Point2D and Rectangle Classes
> ---------------------------------------------
>
> Key: LUCENE-2148
> URL: https://issues.apache.org/jira/browse/LUCENE-2148
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Affects Versions: 3.1
> Reporter: Chris Male
> Assignee: Simon Willnauer
> Attachments: LUCENE-2148.patch
>
>
> The Point2D and Rectangle classes have alot of duplicate, redundant and used
> functionality. This issue cleans them both up and simplifies the
> functionality they provide.
> Subsequent to this, Eclipse and LineSegment, which depend on Point2D, are not
> used anywhere in the contrib, therefore rather than trying to update them to
> use the improved Point2D, they will be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
