[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2122: -------------------------------- Attachment: LUCENE-2122.patch Hi Erick, I spent some time with this patch today and here is what happened: 1. i tried to simplify localizedtestcase, so that it works just like the old one, with the exception of using junit4 parameterized facility. 2. i wrote some bad tests and ensured things worked well such as error messages, default locale being run first, etc etc. 3. i had everything good to go when i got random failures again, this time from 'ant clean test' about 3 times (pass,fail,pass) (sorry i should have done something to capture each test log but i did not) because the only real change here is use of the parameterized facility (the logic is the same), it makes me think that we should stick with .runBare() for the time being, because there is something strange going on here and I'm not even trying to break it. attached is the modified version of your patch. > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTestCase > --------------------------------------------------------------------------------------------------- > > Key: LUCENE-2122 > URL: https://issues.apache.org/jira/browse/LUCENE-2122 > Project: Lucene - Java > Issue Type: Improvement > Components: Other > Affects Versions: 3.1 > Reporter: Erick Erickson > Assignee: Robert Muir > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, > LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch > > > Use the @Parameterized capabilities of Junit4 to allow more extensive testing > of Locales. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org