Thanks for letting me know, it's quite a relief to be able to trust the @Parameterized stuff.
Just let me know if you need me to regenerate the patch whenever you want to apply it. Between now and then I'll find something else to do <G>... Erick On Mon, Dec 14, 2009 at 1:59 PM, Robert Muir <rcm...@gmail.com> wrote: > yeah i am convinced this is not a problem with your junit 4 patch Erick... > as Uwe ran into the same trouble I ran into with the existing > LocalizedTestCase > > however, if you don't mind, I'd like to let it set with the junit 3 impl a > little bit longer and see if we get more random-hard-to-reproduce failures. > > > On Mon, Dec 14, 2009 at 1:46 PM, Erick Erickson > <erickerick...@gmail.com>wrote: > >> Oooh, nice... >> >> >> On Mon, Dec 14, 2009 at 1:26 PM, <rm...@apache.org> wrote: >> >>> Author: rmuir >>> Date: Mon Dec 14 18:26:26 2009 >>> New Revision: 890427 >>> >>> URL: http://svn.apache.org/viewvc?rev=890427&view=rev >>> Log: >>> LUCENE-2155: add assertion to check if something changes default locale >>> behind our back when using LocalizedTestCase >>> >>> Modified: >>> >>> lucene/java/trunk/src/test/org/apache/lucene/util/LocalizedTestCase.java >>> >>> Modified: >>> lucene/java/trunk/src/test/org/apache/lucene/util/LocalizedTestCase.java >>> URL: >>> http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache/lucene/util/LocalizedTestCase.java?rev=890427&r1=890426&r2=890427&view=diff >>> >>> ============================================================================== >>> --- >>> lucene/java/trunk/src/test/org/apache/lucene/util/LocalizedTestCase.java >>> (original) >>> +++ >>> lucene/java/trunk/src/test/org/apache/lucene/util/LocalizedTestCase.java Mon >>> Dec 14 18:26:26 2009 >>> @@ -73,6 +73,8 @@ >>> >>> @Override >>> protected void tearDown() throws Exception { >>> + assertEquals("default locale unexpectedly changed:", locale, Locale >>> + .getDefault()); >>> Locale.setDefault(defaultLocale); >>> super.tearDown(); >>> } >>> >>> >>> >> > > > -- > Robert Muir > rcm...@gmail.com >
