I will try this out later and add an always-failing assert to the code and
try with/without clover. I will add this as a test:
try {
assert false;
fail("asserts disabled")
} catch (AssertionFailedError e} {}
Maybe Nick can explain this to us. This was the same behaviour in clover
1.x.
Maybe it simply because the assert is handled like an if-statement. And if
not both branches of an if-statement are covered, the "if" is red, too.
Or the pre-processor that instruments the java files into temp-dir ignore
asserts. Maybe there is a switch to enable it.
Will post results later.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -----Original Message-----
> From: Michael McCandless [mailto:luc...@mikemccandless.com]
> Sent: Thursday, December 17, 2009 7:36 PM
> To: java-dev@lucene.apache.org
> Subject: Re: Nice, new, and complete coverage reports by Clover 2.6.3 now
> available on hudson
>
> Uwe, do you know why the assert lines come through as not covered?
> Are we not running w/ asserts enabled when we run with clover?
>
> Mike
>
> On Thu, Dec 17, 2009 at 1:25 PM, Uwe Schindler <u...@thetaphi.de> wrote:
> > Hi all,
> >
> > After multiple iterations and failed Hudson build, Mike and me got it
> > running:
> >
> > We upgraded the build.xml and Hudson configuration to use now Clover
> 2.6.3
> > with a new license for Apache projects granted by Nick Pellow from
> > Atlassian. The new reports now cover all tests not only the backwards-
> tests
> > (our complex build structure with test-tag "completely disturbed" R/T
> clover
> > 1.x). You can now see coverage produced by core tests and contrib tests
> > (with linkage between tests and code), and also see coverage of test-tag
> > runs (but here without linkage to the tests):
> >
> > http://hudson.zones.apache.org/hudson/job/Lucene-trunk/clover/
> >
> > Also Hudson now has an own build script that is run as a shell script
> and is
> > available in the nightly SVN (hudson.sh). The build script was optimized
> to
> > no longer use the nightly target and instead produce the results in
> optimal
> > order (but the new Clover version still needs more CPU time). It is also
> > more simple to configure and may be reused for 2.9/3.0 and flex branch
> build
> > (we should do them on Hudson, too; as long as there is development and
> > support for the last Java 1.4 version Lucene Java 2.9).
> >
> > For speed improvement, theoretically the tests without clover could be
> > disabled (within the new shell script), but I kept them online, to have
> > correct stack traces on test failures (because instrumented classes have
> > wrong filenames and line numbers).
> >
> > Nick Pellow also helped us to fix a bug in Clover that produced parse
> > failures in some heavy UTF-8 encoded Java files. Because of that the
> minimum
> > version to run clover with Lucene trunk is 2.6.x. If we will build the
> > branches with Hudson, too, we will backport the patch to the branches,
> too.
> >
> > The required (donated) license is currently available in the JIRA issue
> and
> > also some configuration infos to get your ANT up-to-date:
> > https://issues.apache.org/jira/browse/LUCENE-1769
> > (the license should also work with Eclipse et al.)
> >
> > So again many thanks to Nick Pellow and Atlassian for the license and
> Mike
> > McCandless for always clicking on "build now" in Hudson admin console
> (as we
> > were not able to get a Hudson account for me at all;
> > https://issues.apache.org/jira/browse/INFRA-2326).
> >
> > Happy reviewing code coverage!
> > Uwe Schindler
> >
> > P.S.: Nick, you wanted to send an official mail to this mailing list
> that
> > the new Clover license can be used for every Apache Project even by
> > Non-Committers. I would then forwards the License to the SVN repository.
> >
> > P.P.S.: I also invite the Solr users to upgrade their build!
> >
> > -----
> > Uwe Schindler
> > H.-H.-Meier-Allee 63, D-28213 Bremen
> > http://www.thetaphi.de
> > eMail: u...@thetaphi.de
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: java-dev-h...@lucene.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: java-dev-h...@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
