[ 
https://issues.apache.org/jira/browse/LUCENE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792836#action_12792836
 ] 

Simon Willnauer commented on LUCENE-2147:
-----------------------------------------

chris this looks good I feel that we are pretty close to commit this. I will 
wait another 2 days, review again and announce the commit.

> Improve Spatial Utility like classes
> ------------------------------------
>
>                 Key: LUCENE-2147
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2147
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 3.1
>            Reporter: Chris Male
>            Assignee: Simon Willnauer
>         Attachments: LUCENE-2147.patch, LUCENE-2147.patch, LUCENE-2147.patch
>
>
> - DistanceUnits can be improved by giving functionality to the enum, such as 
> being able to convert between different units, and adding tests.  
> - GeoHashUtils can be improved through some code tidying, documentation, and 
> tests.
> - SpatialConstants allows us to move all constants, such as the radii and 
> circumferences of Earth, to a single consistent location that we can then use 
> throughout the contrib.  This also allows us to improve the transparency of 
> calculations done in the contrib, as users of the contrib can easily see the 
> values being used.  Currently this issues does not migrate classes to use 
> these constants, that will happen in issues related to the appropriate 
> classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to