[ https://issues.apache.org/jira/browse/LUCENE-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794160#action_12794160 ]
Simon Willnauer commented on LUCENE-2169: ----------------------------------------- bq. But you now changed the behaviour of copy(). Before the patch it changed the CharArraySets matchVersion... That was what my patch was doing to preserve this behaviour. the CharArraySet did not have a Version before 3.1 so this code has never been released. Changing this behavior is fine and will not break anything though. simon > Speedup of CharArraySet#copy if a CharArraySet instance is passed to copy. > -------------------------------------------------------------------------- > > Key: LUCENE-2169 > URL: https://issues.apache.org/jira/browse/LUCENE-2169 > Project: Lucene - Java > Issue Type: Improvement > Components: Analysis > Affects Versions: 3.1 > Reporter: Simon Willnauer > Assignee: Uwe Schindler > Fix For: 3.1 > > Attachments: LUCENE-2169.patch, LUCENE-2169.patch, LUCENE-2169.patch, > LUCENE-2169.patch > > > the copy method should use the entries array itself to copy the set > internally instead of iterating over all values. this would speedup copying > even small set -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org