[
https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Rowe updated LUCENE-2200:
--------------------------------
Attachment: LUCENE-2200.patch
bq. Could we make some of the member vars final too?
Done in the new version of the patch. Note that I didn't try to look in
classes other than those already modified in the previous version of the patch
for final class member access modification.
> Several final classes have non-overriding protected members
> -----------------------------------------------------------
>
> Key: LUCENE-2200
> URL: https://issues.apache.org/jira/browse/LUCENE-2200
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Steven Rowe
> Priority: Trivial
> Attachments: LUCENE-2200.patch, LUCENE-2200.patch
>
>
> Protected member access in final classes, except where a protected method
> overrides a superclass's protected method, makes little sense. The attached
> patch converts final classes' protected access on fields to private, removes
> two final classes' unused protected constructors, and converts one final
> class's protected final method to private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
