[
https://issues.apache.org/jira/browse/LUCENE-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798679#action_12798679
]
Steven Rowe commented on LUCENE-2181:
-------------------------------------
+1, tests all pass, and "ant collation" produced expected output.
One minor detail, though - shouldn't the output files be renamed to identify
their purpose, similarly to how you renamed bm2jira.pl? Here's the relevant
section in {{contrib/benchmark/build.txt}}:
{code:xml}
<property name="collation.output.file"
value="${working.dir}/benchmark.output.txt"/>
<property name="collation.jira.output.file"
value="${working.dir}/bm2jira.output.txt"/>
{code}
> benchmark for collation
> -----------------------
>
> Key: LUCENE-2181
> URL: https://issues.apache.org/jira/browse/LUCENE-2181
> Project: Lucene - Java
> Issue Type: New Feature
> Components: contrib/benchmark
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2181.patch, LUCENE-2181.patch, LUCENE-2181.patch,
> LUCENE-2181.patch, LUCENE-2181.patch, LUCENE-2181.patch,
> top.100k.words.de.en.fr.uk.wikipedia.2009-11.tar.bz2
>
>
> Steven Rowe attached a contrib/benchmark-based benchmark for collation (both
> jdk and icu) under LUCENE-2084, along with some instructions to run it...
> I think it would be a nice if we could turn this into a committable patch and
> add it to benchmark.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
