[ https://issues.apache.org/jira/browse/LUCENE-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801212#action_12801212 ]
Robert Muir commented on LUCENE-2212: ------------------------------------- bq. I wonder if we should use GetResourcesAsStream rather than the system property. the resources should always be on the classpath. I don't think we should, because otherwise the test becomes complicated. This test reads thru voc.txt sequentially and for each line in the file, verifies the expected output against the same line in output.txt With ZipFile it does buffering and such transparently to make this very simple. With ZipInputStream i would have to do this myself. > add a test for PorterStemFilter > ------------------------------- > > Key: LUCENE-2212 > URL: https://issues.apache.org/jira/browse/LUCENE-2212 > Project: Lucene - Java > Issue Type: Test > Components: Analysis > Reporter: Robert Muir > Assignee: Robert Muir > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE-2212.patch, porterTestData.zip > > > There are no tests for PorterStemFilter, yet svn history reveals some (very > minor) cleanups, etc. > The only thing executing its code in tests is a test or two in SmartChinese > tests. > This patch runs the StemFilter against Martin Porter's test data set for this > stemmer, checking for expected output. > The zip file is 100KB added to src/test, if this is too large I can change it > to download the data instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org