[ 
https://issues.apache.org/jira/browse/LUCENE-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801221#action_12801221
 ] 

Dawid Weiss commented on LUCENE-2216:
-------------------------------------

This is only true if there is happens-before between the reads and the 
modifications to the object. In any other case other threads may be reading 
stale values (i.e., from their own cache), at least if my understanding of the 
jmm is correct here. Whether you want to rely on such a deep semantics of 
interaction between threads is something to consider deeply, at least in my 
personal opinion.

> OpenBitSet#hashCode() may return false for identical sets.
> ----------------------------------------------------------
>
>                 Key: LUCENE-2216
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2216
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.9, 2.9.1, 3.0
>            Reporter: Dawid Weiss
>            Priority: Minor
>         Attachments: LUCENE-2216.patch, openbitset.patch
>
>
> OpenBitSet uses an internal buffer of long variables to store set bits and an 
> additional 'wlen' index that points 
> to the highest used component inside {...@link #bits} buffer.
> Unlike in JDK, the wlen field is not continuously maintained (on clearing 
> bits, for example). This leads to a situation when wlen may point
> far beyond the last set bit. 
> The hashCode implementation iterates over all long components of the bits 
> buffer, rotating the hash even for empty components. This is against the 
> contract of hashCode-equals. The following test case illustrates this:
> {code}
> // initialize two bitsets with different capacity (bits length).
> BitSet bs1 = new BitSet(200);
> BitSet bs2 = new BitSet(64);
> // set the same bit.
> bs1.set(3);
> bs2.set(3);
>         
> // equals returns true (passes).
> assertEquals(bs1, bs2);
> // hashCode returns false (against contract).
> assertEquals(bs1.hashCode(), bs2.hashCode());
> {code}
> Fix and test case attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to