[ 
https://issues.apache.org/jira/browse/LUCENE-2222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801770#action_12801770
 ] 

Renaud Delbru commented on LUCENE-2222:
---------------------------------------

For the moment, I first try to use FrameOfRef, and compare it with some simpler 
encoding methods such as VInt using the Codec interface. I would like to see if 
the BlockReader and Reader interface do not add too much overhead compared to a 
simple index input based on vint, and therefore loose the speed benefits we got 
on decompression.

I agree with your modifications, it is more clean. I have applied the patch, 
and run the tests, all seems to run without problems.

P.S.: I had some problems (errors on CHANGES.txt and 
FixedIntBlockIndexInput.java) when applying the patch (within eclipse). I had 
to do it manually, Don't know what is the cause.
P.S.: Sorry for the first patches, my eclipse is configured to format 
automatically the code (add final, this., etc.) and therefore my patches are 
generally including all these modifications. Is it a problem for you ?

> FixedIntBlockIndexInput.Reader does not initialise 'pending' int array
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-2222
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2222
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: Flex Branch
>            Reporter: Renaud Delbru
>            Priority: Minor
>             Fix For: Flex Branch
>
>         Attachments: LUCENE-2222.patch, LUCENE-2222.patch, LUCENE-2222.patch
>
>
> The FixedIntBlockIndexInput.Reader.pending int array is not initialised. As a 
> consequence, the FixedIntBlockIndexInput.Reader#next() method returns always 
> 0.
> A call to FixedIntBlockIndexInput.Reader#blockReader.readBlock() during the 
> Reader initialisation may solve the issue (to be tested).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to