[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806228#action_12806228 ]
Robert Muir commented on LUCENE-2218: ------------------------------------- Steven: ok I reviewed this patch, I really like it. I think the new options make this filter more useful, and improved performance on top of this. I also feel the new code is easier to understand. I will commit in a few days if no one objects. > ShingleFilter improvements > -------------------------- > > Key: LUCENE-2218 > URL: https://issues.apache.org/jira/browse/LUCENE-2218 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/analyzers > Affects Versions: 3.0 > Reporter: Steven Rowe > Assignee: Robert Muir > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE-2118.patch, LUCENE-2218.patch > > > ShingleFilter should allow configuration of minimum shingle size (in addition > to maximum shingle size), so that it's possible to (e.g.) output only > trigrams instead of bigrams mixed with trigrams. The token separator used in > composing shingles should be configurable too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org