[
https://issues.apache.org/jira/browse/LUCENE-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829687#action_12829687
]
Simon Willnauer commented on LUCENE-2055:
-----------------------------------------
Robert, nice work!
I have one comment on StemmerOverrideFilter
The ctor should not always copy the given dictionary dictionary - if is created
with such a map we should use the given instance. This is similar to StopFilter
vs. StopAnalyzer.
Maybe a CharArrayMap.castOrCopy(Map<?, String>) would be handy in that case.
One minor thing, the null check in DutchAnalyzer seems to be unnecessary but
anyway thats fine.
{code}
if (stemdict != null && !stemdict.isEmpty())
{code}
DutchAnalyzer also has an unused import
{code}
import java.util.Arrays;
{code}
except of those +1 from my side
> Fix buggy stemmers and Remove duplicate analysis functionality
> --------------------------------------------------------------
>
> Key: LUCENE-2055
> URL: https://issues.apache.org/jira/browse/LUCENE-2055
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/analyzers
> Reporter: Robert Muir
> Fix For: 3.1
>
> Attachments: LUCENE-2055.patch, LUCENE-2055.patch, LUCENE-2055.patch,
> LUCENE-2055.patch
>
>
> would like to remove stemmers in the following packages, and instead in their
> analyzers use a SnowballStemFilter instead.
> * analyzers/fr
> * analyzers/nl
> * analyzers/ru
> below are excerpts from this code where they proudly proclaim they use the
> snowball algorithm.
> I think we should delete all of this custom stemming code in favor of the
> actual snowball package.
> {noformat}
> /**
> * A stemmer for French words.
> * <p>
> * The algorithm is based on the work of
> * Dr Martin Porter on his snowball project<br>
> * refer to http://snowball.sourceforge.net/french/stemmer.html<br>
> * (French stemming algorithm) for details
> * </p>
> */
> public class FrenchStemmer {
> /**
> * A stemmer for Dutch words.
> * <p>
> * The algorithm is an implementation of
> * the <a
> href="http://snowball.tartarus.org/algorithms/dutch/stemmer.html";>dutch
> stemming</a>
> * algorithm in Martin Porter's snowball project.
> * </p>
> */
> public class DutchStemmer {
> /**
> * Russian stemming algorithm implementation (see
> http://snowball.sourceforge.net for detailed description).
> */
> class RussianStemmer
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
