[
https://issues.apache.org/jira/browse/LUCENE-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831901#action_12831901
]
Uwe Schindler commented on LUCENE-2111:
---------------------------------------
Mike: I reviewed this EmptyTermsEnum in MTQ. I would leave it in, but simply
make EmptyTermsEnum a singleton (which is perfectly fine, because its
stateless). Returning null here makes no performance in MTQs, it only makes the
code in MTQ#rewrite and MTQWF#getDocIdSet ugly. The biggest problem with
returning null here is the backwards layer that must be fixed then (because it
checks if getTermsEnum return null and falls back to FilteredTermEnum from
trunk). If you really want null, getTermsEnum should per default (if not
overriddden) throw UOE and the rewrite code should catch this UOE and only then
delegate to backwards layer.
> Wrapup flexible indexing
> ------------------------
>
> Key: LUCENE-2111
> URL: https://issues.apache.org/jira/browse/LUCENE-2111
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: Flex Branch
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE-2111.patch, LUCENE-2111.patch, LUCENE-2111.patch,
> LUCENE-2111.patch, LUCENE-2111.patch, LUCENE-2111.patch, LUCENE-2111.patch,
> LUCENE-2111_fuzzy.patch
>
>
> Spinoff from LUCENE-1458.
> The flex branch is in fairly good shape -- all tests pass, initial search
> performance testing looks good, it survived several visits from the Unicode
> policeman ;)
> But it still has a number of nocommits, could use some more scrutiny
> especially on the "emulate old API on flex index" and vice/versa code paths,
> and still needs some more performance testing. I'll do these under this
> issue, and we should open separate issues for other self contained fixes.
> The end is in sight!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
