[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832483#action_12832483
]
Mark Harwood commented on LUCENE-1720:
--------------------------------------
Agreed, might be useful to provide boolean response to the progress method - a
kind of "how am I doing?" check.
We can always provide a convenience wrapper method which throws an exception :
ATM.blowUpIfNotGoingFastEnough(float progress)
Re TimeLimitingCollector - agreed, you really do need to protect ATM/start/stop
calls in the same try...finally block.
Maybe ATM could have a "start" method variant that takes an additional
"alreadyRunningSince" argument as opposed to the existing assumption that the
activity is starting right now. The first "collect" could then call this with a
timestamp initialised in the constructor.
Even then, there is the issue of where to put the "stop" call - collector has
no "close" call to signal the end of the activity.
Doesn't seem like TimeLimitingCollector can be based on the same ATM code.
Shame.
> TimeLimitedIndexReader and associated utility class
> ---------------------------------------------------
>
> Key: LUCENE-1720
> URL: https://issues.apache.org/jira/browse/LUCENE-1720
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Index
> Reporter: Mark Harwood
> Assignee: Mark Harwood
> Priority: Minor
> Attachments: ActivityTimedOutException.java,
> ActivityTimeMonitor.java, ActivityTimeMonitor.java, ActivityTimeMonitor.java,
> LUCENE-1720.patch, TestTimeLimitedIndexReader.java,
> TestTimeLimitedIndexReader.java, TimeLimitedIndexReader.java,
> TimeLimitedIndexReader.java
>
>
> An alternative to TimeLimitedCollector that has the following advantages:
> 1) Any reader activity can be time-limited rather than just single searches
> e.g. the document retrieve phase.
> 2) Times out faster (i.e. runaway queries such as fuzzies detected quickly
> before last "collect" stage of query processing)
> Uses new utility timeout class that is independent of IndexReader.
> Initial contribution includes a performance test class but not had time as
> yet to work up a formal Junit test.
> TimeLimitedIndexReader is coded as JDK1.5 but can easily be undone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
