[
https://issues.apache.org/jira/browse/LUCENE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839364#action_12839364
]
Shai Erera commented on LUCENE-2288:
------------------------------------
Thanks Robert. I never checked if those methods are actually code, as I didn't
do it to earn any CPU cycles back. I just followed good coding practice, and
since it appeared in two places, thought that a constant will look like a bit
less waste. If you're sure those are not called by the other stemmers (and I'm
sure you are :)), then I'm fine if you leave those out as well ;)
> Create EMPTY_ARGS constsant in SnowballProgram instead of allocating new
> Object[0]
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-2288
> URL: https://issues.apache.org/jira/browse/LUCENE-2288
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Shai Erera
> Assignee: Robert Muir
> Fix For: 3.1
>
> Attachments: LUCENE--2288.patch
>
>
> Instead of allocating new Object[0] create a proper constant in
> SnowballProgram. The same (for new Class[0]) is created in Among, although
> it's less critical because Among is called from static initializers ... Patch
> will follow shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
