[ 
https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839442#action_12839442
 ] 

Michael McCandless commented on LUCENE-2289:
--------------------------------------------

Shai, which version did you generate the patch on?  I hit one odd hunk failure 
in applying the patch to trunk, because your version doesn't have an "if (exc 
!= null)" check...

> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-2289
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2289
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on 
> strings, calls to message should be wrapped w/ infoStream != null check, 
> rather than inside message(). I'll attach a patch which does that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to