What's ok? making the classes final or just the method declaration? If classes, besides ReadOnlySegmentReader, which other impls do you think can be made final (I'm not in front of the code)?
On Sun, Feb 28, 2010 at 7:05 PM, Michael McCandless < [email protected]> wrote: > Seems OK I think? > > Mike > > On Sun, Feb 28, 2010 at 12:37 AM, Shai Erera <[email protected]> wrote: > > Hi > > > > Do you think it's worth to make some of the isDeleted method impls final, > > like in ReadOnlySegmentReader and (maybe) DirectoryReader? I'm thinking > the > > classes that are perceived as final could benefit from that, since their > > impl could be inlined. Maybe just make these classes final entirely? > > > > Shai > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
