[ 
https://issues.apache.org/jira/browse/LUCENE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-2303:
----------------------------------

    Attachment: LUCENE-2303.patch

Updated patch that also moves the DEFAULT_TYPE constant into the interface. 
This removes code duplication, too. Backwards tests pass.

> Remove code duplication from Token class, just extend TermAttributeImpl
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-2303
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2303
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2303.patch, LUCENE-2303.patch
>
>
> This issue removes the code duplication from Token, as it shares the whole 
> char[] buffer handling code with TermAttributeImpl. This issue removes this 
> duplication by just extending TermAttributeImpl.
> When the parent issue LUCENE-2302 will extend TermAttribute to support 
> CharSequence and Appendable and also the new BytesRefAttribute gets added, 
> Token will automatically provide this too, so no further code duplication.
> This code should also be committed to trunk, as it has nothing to do with 
> flex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to