[
https://issues.apache.org/jira/browse/LUCENE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cédrik LIME updated LUCENE-2015:
--------------------------------
Attachment: LUCENE-2015.patch
Robert: I liked the dual approach (fold 1 {{char}} / a {{char[]}}) as it
offered maximum flexibility (folding a String didn't incur a systematic copy of
the input as {{toCharArray()}} does, I could use {{charAt()}} in a loop).
Nevertheless, I will be happy with a single method if this is your preferred
approach.
I have updated your patch slightly to model the API after
{{System.arraycopy()}}, which makes it a bit more flexible and easier to use:
* added offset for output
* shuffled the arguments order to mimic {{System.arraycopy()}}
* updated JavaDoc
> ASCIIFoldingFilter: expose folding logic + small improvements to
> ISOLatin1AccentFilter
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-2015
> URL: https://issues.apache.org/jira/browse/LUCENE-2015
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Cédrik LIME
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: ASCIIFoldingFilter-no_formatting.patch,
> ASCIIFoldingFilter-no_formatting.patch, Filters.patch,
> ISOLatin1AccentFilter.patch, LUCENE-2015.patch, LUCENE-2015.patch
>
>
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (namely:
> left & right single quotation marks, en dash, em dash) which we very
> frequently encounter in our projects. I know that this class is now
> deprecated; this improvement is for legacy code that hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in
> ASCIIFoldingFilter for potential re-use in non-Lucene-related code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
