[ https://issues.apache.org/jira/browse/LUCENE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844250#action_12844250 ]
Earwin Burrfoot commented on LUCENE-2311: ----------------------------------------- Not only newly created, but newly opened too! So your readers are warmed, if you just created an IW, called getReader, and didn't do any writes at all yet. > Pass potent SR to IRWarmer.warm(), and also call warm() for new segments > ------------------------------------------------------------------------ > > Key: LUCENE-2311 > URL: https://issues.apache.org/jira/browse/LUCENE-2311 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Earwin Burrfoot > Fix For: 3.1 > > > Currently warm() receives a SegmentReader without terms index and docstores. > It would be arguably more useful for the app to receive a fully loaded > reader, so it can actually fire up some caches. If the warmer is undefined on > IW, we probably leave things as they are. > It is also arguably more concise and clear to call warm() on all newly > created segments, so there is a single point of warming readers in NRT > context, and every subreader coming from getReader is guaranteed to be warmed > up -> you don't have to introduce even more mess in your code by rechecking > it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org