[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845129#action_12845129
]
Chris Male commented on LUCENE-2310:
------------------------------------
Hi Shai,
{quote}
How about if getFields() will return an Iterable<Field>? It'll need to be
deprecated and a new method created, but it can be simple enough solution to
avoid one adding fields directly to Document w/o passing through doc.add first.
{quote}
I'm not really in favour of Iterable in this case as it inhibits people calling
.size(). Knowing how many fields a Document has might be useful. But I agree
it would certainly prevent people from adding new Fields and is a simple
solution. Do you think getting the number of fields has a use case at all?
{quote}
If you do end up removing getFields(), then I'd like to have a clear() on
Document. I once proposed it and was told to call getFields().clear() instead,
which allows me to reuse my Document instance. If I lose that option, I'd
appreciate if a direct clear() on Document will exist instead.
{quote}
Yes. I will certainly add clear(). Do you think its useful to support
removing specific fields as well i.e. remove(String fieldName)?
> Reduce Fieldable, AbstractField and Field complexity
> ----------------------------------------------------
>
> Key: LUCENE-2310
> URL: https://issues.apache.org/jira/browse/LUCENE-2310
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: Index
> Reporter: Chris Male
> Attachments: LUCENE-2310-Deprecate-AbstractField.patch,
> LUCENE-2310-Deprecate-AbstractField.patch,
> LUCENE-2310-Deprecate-AbstractField.patch
>
>
> In order to move field type like functionality into its own class, we really
> need to try to tackle the hierarchy of Fieldable, AbstractField and Field.
> Currently AbstractField depends on Field, and does not provide much more
> functionality that storing fields, most of which are being moved over to
> FieldType. Therefore it seems ideal to try to deprecate AbstractField (and
> possible Fieldable), moving much of the functionality into Field and
> FieldType.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
