[
https://issues.apache.org/jira/browse/LUCENE-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846537#action_12846537
]
Michael McCandless commented on LUCENE-2305:
--------------------------------------------
Hmm... I think true is likely the better default (since it will tend, more, to
merge segments that have many deletes)?
I had said leave it as false because we missed this TODO in 3.0.
But... if we add Version to MP (I think that makes sense) then I think we
should flip the default?
> Introduce Version in more places long before 4.0
> ------------------------------------------------
>
> Key: LUCENE-2305
> URL: https://issues.apache.org/jira/browse/LUCENE-2305
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Fix For: 3.1
>
>
> We need to introduce Version in as many places as we can (wherever it makes
> sense of course), and preferably long before 4.0 (or shall I say 3.9?) is
> out. That way, we can have a bunch of deprecated API now, that will be gone
> in 4.0, rather than doing it one class at a time and never finish :).
> The purpose is to introduce Version wherever it is mandatory now, and also in
> places where we think it might be useful in the future (like most of our
> Analyzers, configured classes and configuration classes).
> I marked this issue for 3.1, though I don't expect it to end in 3.1. I still
> think it will be done one step at a time, perhaps for cluster of classes
> together. But on the other hand I don't want to mark it for 4.0.0 because
> that needs to be resolved much sooner. So if I had a 3.9 version defined, I'd
> mark it for 3.9. We can do several commits in one issue right? So this one
> can live for a while in JIRA, while we gradually convert more and more
> classes.
> The first candidate is InstantiatedIndexWriter which probably should take an
> IndexWriterConfig. While I converted the code to use IWC, I've noticed
> Instantiated defaults its maxFieldLength to the current default (10,000)
> which is deprecated. I couldn't change it for back-compat reasons. But we can
> upgrade it to accept IWC, and set to unlimited if the version is onOrAfter
> 3.1, otherwise stay w/ the deprecated default.
> if it's acceptable to have several commits in one issue, I can start w/
> Instantiated, post a patch and then we can continue to more classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
