[ https://issues.apache.org/jira/browse/LUCENE-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849228#action_12849228 ]
Michael McCandless commented on LUCENE-2344: -------------------------------------------- Patch looks great -- I like the new unit test. I'm going to try to get some of our tests to actively test the other codecs so we catch this sort of thing sooner... > PostingsConsumer#merge does not call finishDoc > ---------------------------------------------- > > Key: LUCENE-2344 > URL: https://issues.apache.org/jira/browse/LUCENE-2344 > Project: Lucene - Java > Issue Type: Bug > Components: Index > Affects Versions: Flex Branch > Reporter: Renaud Delbru > Assignee: Michael McCandless > Fix For: Flex Branch > > Attachments: LUCENE-2344.patch > > > We discovered that the current merge function in PostingsConsumer is not > calling the #finishDoc method. This does not have consequences for the > standard codec (since the lastPosition is set to 0 in #startDoc, and its > #finishDoc method is empty), but for the SepCodec, this results in position > file corruption (the lastPosition is set to 0 in #finishDoc for the SepCodec). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org