[ 
https://issues.apache.org/jira/browse/LUCENE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849352#action_12849352
 ] 

Uwe Schindler commented on LUCENE-2338:
---------------------------------------

Hi Sanjoy,

just grep on "printStackTrace(" to find test cases that simply print out 
stacktraces and ignore exceptions. Possible examples can be seen also in 
related issues like LUCENE-1814.

Thanks for your interest in fixing this!

> Some tests catch Exceptions in separate threads and just print a stack trace 
> - the test does not fail
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2338
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2338
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Uwe Schindler
>
> Some tests catch Exceptions in separate threads and just print a stack trace 
> - the test does not fail. The test should fail. Since LUCENE-2274, the 
> LuceneTestCase(J4) class installs an UncaughtExceptionHandler, so this type 
> of catching and solely printing a Stack trace is a bad idea. Problem is, that 
> the run() method of threads is not allowed to throw checked Exceptions.
> Two possibilities:
> - Catch checked Exceptions in the run() method and wrap into RuntimeException 
> or call Assert.fail() instead
> - Use Executors

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to