[ 
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849863#action_12849863
 ] 

Michael McCandless commented on LUCENE-2215:
--------------------------------------------

bq. ...through a fairly simple update of some of the clauses to appropriate 
short circuit things that we can just hook this into the existing collectors 
w/o no need for any delegation or changes? Let me try a patch. Now that the 
benchmark stuff is in, we should be able to test.

This'd make me nervous...

Ie I don't think we should insert bytecodes for the 99.9% of searches that 
wouldn't make use of this, even if we can't uncover a slowdown with 
benchmarking.

We should still benchmark it though (I'm curious)... we should also benchmark 
the delegate solution.

> paging collector
> ----------------
>
>                 Key: LUCENE-2215
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2215
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4, 3.0
>            Reporter: Adam Heinz
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: IterablePaging.java, LUCENE-2215.patch, 
> PagingCollector.java, TestingPagingCollector.java
>
>
> http://issues.apache.org/jira/browse/LUCENE-2127?focusedCommentId=12796898&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12796898
> Somebody assign this to Aaron McCurry and we'll see if we can get enough 
> votes on this issue to convince him to upload his patch.  :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to