[
https://issues.apache.org/jira/browse/LUCENE-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850036#action_12850036
]
Cristian Vat commented on LUCENE-2349:
--------------------------------------
Do they have to be unique? From my understanding they only need to be unique
inside one thread.
Could we make TEMP_DIR (in LuceneTestCaseJ4) a ThreadLocal<File> ?
If TEMP_DIR inside LuceneTestCase weren't final, we could make its assignment
get the actual File value, so no changes in the actual tests would be necessary.
> Tests should use unique temporary directories
> ---------------------------------------------
>
> Key: LUCENE-2349
> URL: https://issues.apache.org/jira/browse/LUCENE-2349
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Affects Versions: 3.1
> Reporter: Robert Muir
>
> We cannot safely use parallel tests (LUCENE-1709) because some test classes
> try to use temporary directories with the same name.
> So if these two happen to run at the same time, they conflict.
> For example TestIndexReader has code like this:
> {code}
> File dirFile = new File(TEMP_DIR, "testIndex");
> {code}
> But TestCompoundFile has similar code:
> {code}
> File file = new File(TEMP_DIR, "testIndex");
> {code}
> If both these classes run at the same time, there will be problems.
> If we want to use parallel tests safely, we have to fix this use of the
> static TEMP_DIR which does not include any unique name of the test.
> Ideally we can do this without changing a lot of test code, especially
> backwards.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
