[ 
https://issues.apache.org/jira/browse/LUCENE-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-2372:
----------------------------------

    Attachment: LUCENE-2372.patch

Small updates.

Just one question: The only non-final Analyzer left is KeywordAnalyzer. If I 
make it final and also use ReusableTokenizerBase, we can remove the 
overridesTokenStream check completely? The question is, whoever wants to 
override this class.

StandardAnalyzer was made final in this patch, why not also this one?

> Replace deprecated TermAttribute by new CharTermAttribute
> ---------------------------------------------------------
>
>                 Key: LUCENE-2372
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2372
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.1
>            Reporter: Uwe Schindler
>             Fix For: 3.1
>
>         Attachments: LUCENE-2372.patch, LUCENE-2372.patch, LUCENE-2372.patch
>
>
> After LUCENE-2302 is merged to trunk with flex, we need to carry over all 
> tokenizers and consumers of the TokenStreams to the new CharTermAttribute.
> We should also think about adding a AttributeFactory that creates a subclass 
> of CharTermAttributeImpl that returns collation keys in toBytesRef() 
> accessor. CollationKeyFilter is then obsolete, instead you can simply convert 
> every TokenStream to indexing only CollationKeys by changing the attribute 
> implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to