[ 
https://issues.apache.org/jira/browse/LUCENE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858108#action_12858108
 ] 

Uwe Schindler commented on LUCENE-2399:
---------------------------------------

I know, you were running the test without assertion from Eclipse! :-)

{noformat}
[junit] TokenStream implementation classes or at least their incrementToken() 
implementation must be final
[junit] junit.framework.AssertionFailedError: TokenStream implementation 
classes or at least their incrementToken() implementation must be final
[junit]     at 
org.apache.lucene.analysis.TokenStream.assertFinal(TokenStream.java:117)
{noformat}

So for me the assertion worked. The *second* patch of course works with 
icu-4_4.jar! So great and I am happy about the cool interfaces at 
CharTermAttribute.

I just wanted to check that the my deputy sheriff did not miss something 
because of wrong instructions.

> Add support for ICU's Normalizer2
> ---------------------------------
>
>                 Key: LUCENE-2399
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2399
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: contrib/*
>    Affects Versions: 3.1
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.1
>
>         Attachments: LUCENE-2399.patch, LUCENE-2399.patch
>
>
> While there are separate Case Folding, Normalization, and Ignorable-removal 
> filters in LUCENE-1488,
> the new ICU Normalizer2 API does this all at once with nfkc_cf (based on the 
> new NFKC_Casefold property in Unicode).
> This is great, because it provides a ton of unicode functionality that is 
> really needed.
> And the new Normalizer2 API takes CharSequence and writes to Appendable...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to