I would also suggest to improve the exception for the ConverterUtil Line 927

Date / Calendar
=> the exception just says "invalid date format ($yourstring) with out - s
at correct place

Actually the message is wrong cause if you have no ":" or "T" in the string
there will be still saying "without - s at correct place" ...
However it would be also nice if it would tell you the correct pattern(s).
You can actually only find out the correct patterns by looking at the
ConverterUtil.java source code

A more handy Exception would be:
"invalid date format ($yourstring) with out - s at correct place - correct
patterns are [yyyy-mm-ddThh:mm:ss sample 2012:12:01T12:30:00] or .... "

Could you please fill which alternatives patterns are accepted, it seems
like
2012:12:01T12:30:00: 55.437Z
or
2012:12:01T12:30:00 -0800
are also accepted but not sure


Sebastian














2012/3/15 seba.wag...@gmail.com <seba.wag...@gmail.com>

> I have a request and would like to discuss if it is worth opening an Jira
> issue for it:
>
> If you pass a parameter that axis is unable to parse the output in the log
> looks like:
> java.lang.RuntimeException: In valid string sufix
>     at
> org.apache.axis2.databinding.utils.ConverterUtil.convertToDate(ConverterUtil.java:596)
>
> Now the experienced developer might look at any Date parameter in the
> SOAP/REST request in the above example.
>
> However it would be good if the exception would actually give the name of
> the parameter that failed!
> It is much easier to debug / fix your RPC calls if the RPC Gateway
> actually can tell you which parameter is wrong instead of just failing with
> some kind of cryptic stack trace pointing to internal classes of Axis2 that
> might (or might not) give somebody an idea which parameters to look at.
> So the idea would be that the RunTimeException String message would be
> something like:
> Invalid string sufix at parameter "myDate" in method "myMethod"
> [€ventually + Service Name]
>
> I think that would improve the usability a lot for end users.
> What do you think?
>
> Thanks!
> Sebastian
> --
> Sebastian Wagner
> http://www.openmeetings.de
> http://incubator.apache.org/openmeetings/
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> seba.wag...@gmail.com
>



-- 
Sebastian Wagner
http://www.openmeetings.de
http://incubator.apache.org/openmeetings/
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wag...@gmail.com

Reply via email to