Sine my objective is to undersdand BlockGroupingCollector, I thought I would extract a test for BlockGroupingCollector, maybe in another file as Robert suggested.
I was looking at testRandom because that is where BlockGroupingCollector is tested, but it looks to me like some trickery is involved creating the block join type index near the comment where it says" // Build 2nd index, where docs are added in blocks by group, so we can use single pass collector " In testBasic, I can see the call to indexWriter.addDocuments(), but I don't see that happening anywhere in testRandom. Should I just be looking at testBasic for a simple/understandable way to create a block-join index for later testing of the BlockGroupingCollector? Also I'm a bit confused by the use of Doc Values. Is that necessary to use the BlockGroupingCollector, or are they in there in order to test some feature related to Doc Values and the Collectors? Tom On Tue, Jun 18, 2013 at 1:14 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > +1 to somehow refactor this scary test to make it more understandable! > > Mike McCandless > > http://blog.mikemccandless.com > > > On Tue, Jun 18, 2013 at 12:48 PM, Tom Burton-West <tburt...@umich.edu> > wrote: > > Hello, > > > > I'm trying to understand BlockGroupingCollector. I thought I would > start > > by running the tests in the debugger. However the only test I can find > is > > > lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java > > > > > > In TestGrouping.java, in the second test, "testRandom" it seems like a > > fairly large number of things are tested, including a test of > > BlockGroupingCollector. > > > > I'm having a hard time understanding the tests and wonder if perhaps > > TestGrouping.java might be refactored to make it easier to understand. > > > > Is there some reason that separate tests are not broken out? > > I also could not find setup and teardown methods. Is there some reason > > they are not being used? > > Would it make sense to open a JIRA issue to refactor TestGrouping.java > to > > make a clearer separation between different things being tested? > > In particular, perhaps BlockGroupingCollector could have a separate test? > > > > Tom > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-user-h...@lucene.apache.org > >
