I looked at it, I could not see anything wrong, Bhavesh knows
more about these things than I do.

Kumar

On 2/20/2014 5:59 AM, Yuri Nesterenko wrote:
Thank you Jon!

Bhavesh, Kumar, could you please also take a look?
It's just a trifle for tidy cleanup.

Thanks,
-yan

On 02/19/2014 10:33 PM, Jonathan Gibbons wrote:
Looks good to me.

-- Jon


On 02/12/2014 03:48 AM, Yuri Nesterenko wrote:
Here's a second version, please review:
http://cr.openjdk.java.net/~yan/6457406/webrev.01

A regression test added. One substring call instead of yesterday's two,
as Jonathan suggested in a comment to
https://bugs.openjdk.java.net/browse/JDK-6457406

With new version again, tidy cannot find any more similar issues
in the generated documents.

Thanks,
-yan


On 02/11/2014 07:44 PM, Yuri Nesterenko wrote:
Hi,

could you please review this small fix to
https://bugs.openjdk.java.net/browse/JDK-6457406 ?

It's hard to understand what is broken from (the HTML) description in
the bug report.
Currently, when javadoc does generate an index or summary document
and encounters a full URL, with protocol and everything,
in single quotes, it treats it as a relative URL.
Results is, a string in href="" concatenating docRoot and original
URL. Any browser shows this quite unpredictably.


Webrev:
http://cr.openjdk.java.net/~yan/6457406/webrev.00

Result was run through tidy: some 67 errors less.

Thanks,
-yan




Reply via email to