Hi Jon, Looks ok to me.
Thanks Kumar Srinivasan On Fri, May 18, 2018 at 3:51 PM, Jonathan Gibbons < [email protected]> wrote: > Please review a small source change and corresponding test updates to > javadoc, > so that the behavior is to not generate frames by default. (A future > release will > remove support for frames altogether.) > > Most test changes are tiny, and correspond to adding "--frames" to restore > the previous behavior. There should be a followup bug to change the test to > work without the --frames option. The small test changes are best viewed > through > Udiffs links. One test has non-trivial changes: > TestFramesNoFramesTest.java. > > The change is dependent on the CSR being approved. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8196202 > CSR: https://bugs.openjdk.java.net/browse/JDK-8202961 > Webrev: http://cr.openjdk.java.net/~jjg/8196202/webrev.00/ > > -- Jon >
