Priya,
An alternative would have been to leave most of getTypeParameterLinks in
place
and then introduce new method get get the zero-width spac e, but this
is OK.
The webrev is hard to read, because it looks like the "webrev" utility
is not handling
the entity correctly. However, the patch file looks OK.
In the stylesheet file, line 825, put a space between "pre" and "{". No
need for a re-review
for just that change.
-- Jon
On 06/26/2018 08:47 AM, Priya Lakshmi Muthuswamy wrote:
Thanks Jon for the comments.
Updated webrev :
http://cr.openjdk.java.net/~pmuthuswamy/8187288/webrev.01/
Thanks,
Priya
On 6/25/2018 10:24 PM, Jonathan Gibbons wrote:
On 6/15/18 5:42 AM, Priya Lakshmi Muthuswamy wrote:
Hi,
Kindly review the fix for
https://bugs.openjdk.java.net/browse/JDK-8187288
webrev: http://cr.openjdk.java.net/~pmuthuswamy/8187288/webrev.00/
Thanks,
Priya
This fix has the problem that you have an "inappropriate" import in
the toolkit
package for a class from the formats.html package. The intended
design is that
the toolkit packages are "format neutral" and do not depend on any
specific
output format. Although we don't use that feature today, in the past
it has been
used to generate alternate output files, like FrameMaker etc.
Although it need not be part of this work, we should revive the idea
of having
tests that verify that imports follow the intended constraints. We
did this with
some amount of scripting during the doclet conversion; I'll see what
can be
done in a more formal manner.
-- Jon
