Looks fine Jon; thanks,
-Joe
On 11/1/2018 2:20 PM, Jonathan Gibbons wrote:
Please review a tedious but conceptually simple update to fix the
legal headers in a lot of test/langtools files.
The change is to remove the '"Classpath" exception' from the header,
which should not be used in test files.
The change was made by executing the following script:
grep -rl '"Classpath" exception' test/langtools | xargs sed --in-place \
-e 's/ Oracle designates this//' \
-e '/particular file as subject to the "Classpath" exception as
provided/d' \
-e '/by Oracle in the LICENSE file that accompanied this code./d'
After applying the script and running the tests, two tests failed.
These two tests were golden-file tests and were internally
inconsistent: they had a full legal header, in addition to the special
token "/nodynamiccopyright/" to justify that they should not have a
full legal header. These tests, and their golden files, were manually
updated. The affected files were:
test/langtools/tools/javac/lvti/T8200199.java
test/langtools/tools/javac/lvti/T8200199.out
test/langtools/tools/javac/lvti/badTypeReference/BadTypeReference.java
test/langtools/tools/javac/lvti/badTypeReference/BadTypeReference.out
JBS: https://bugs.openjdk.java.net/browse/JDK-8213263
Webrev: http://cr.openjdk.java.net/~jjg/8213263/webrev.00/
With the exception of the 4 files listed above, it may be easiest to
scan through the patch file directly.
-- Jon
