Looks good. Hannes
> Am 20.11.2018 um 23:19 schrieb Jonathan Gibbons <[email protected]>: > > Please review a conceptually simple cleanup for the doclet code. > > The change is: > > • replace all uses of all overloads of Configuration.getText with the > underlying implementation of Resources.getText > • replace all uses of all overloads of Configuration.getContent with > the underlying implementation of Contents.getContent > • remove all overloads of Configuration.getText > • remove all overloads of Configuration.getContent > The change is mostly mechanical, via an IDE, with some minor manual fixup. > The most notable manual change is to defer initializing Extern so that we can > cache Configuration.getResources. > > The changes are all very localized, so it may be easy to read the overall > patch, or the Udiffs in the webrev than the side-by-side diffs. > > noreg-cleanup, so no tests. All the tests still pass, and "make docs" is the > same before and after. > JBS: https://bugs.openjdk.java.net/browse/JDK-8214139 > Webrev: http://cr.openjdk.java.net/~jjg/8214139/webrev.00/ > > -- Jon
