Looks good to me! Hannes
> Am 29.01.2019 um 07:22 schrieb Priya Lakshmi Muthuswamy > <priya.lakshmi.muthusw...@oracle.com>: > > Hi Hannes, > > Thanks for the review. > I have removed the unused summary string computation from the code. > webrev : http://cr.openjdk.java.net/~pmuthuswamy/8215577/webrev.02/ > > Thanks, > Priya > > On 1/28/2019 8:48 PM, Hannes Wallnöfer wrote: >> Hi Priya, >> >> In quite a few places where Table#setSummary used to be called, the summary >> string for that call is still computed or at least passed around without >> being used. I think this is the case for all classes implementing >> AbstractMemberWriter#createSummaryTable(): >> >> AnnotationTypeFieldWriterImpl >> AnnotationTypeRequiredMemberWriterImpl (method getTableSummary() is never >> used) >> ConstructorWriterImpl >> EnumConstantWriterImpl >> FieldWriterImpl >> MethodWriterImpl >> NestedClassWriterImpl >> PropertyWriterImpl >> >> There may be a few other passing around summary arguments that aren’t used. >> >> Otherwise your patch looks good to me. >> >> Hannes >> >> >>> Am 28.01.2019 um 10:48 schrieb Priya Lakshmi Muthuswamy >>> <priya.lakshmi.muthusw...@oracle.com>: >>> >>> forgot to mention CSR . >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215577 >>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8215577/webrev.01/ >>> CSR : https://bugs.openjdk.java.net/browse/JDK-8215578 >>> >>> Thanks, >>> Priya >>> On 1/28/2019 10:14 AM, Priya Lakshmi Muthuswamy wrote: >>>> Hi, >>>> >>>> Kindly review the changes for the removal for html4 support from javadoc. >>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215577 >>>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8215577/webrev.01/ >>>> >>>> Thanks, >>>> Priya >>>>
