Hi, In this mailing lists archive I can only find the review request mail for the fix for JDK-8218936 [0]. But in JIRA, I find the issue resolved with a review by Mandy. I expect the review mail had been sent on this mailing list but for some reason, the review mail is not shown. I suspect this is due to the moderator approval for mails on this list which maybe has not been given. Is that true?
Is there a reason why mails by registered list members need moderator approval here? I find it kind of unhandy to not see mails getting posted immediately. Also threads like this one [1] are hardly readable from the outside. So, could you either explain the reasoning of this restrictive mailing list behavior or even change this? Thanks & Best regards Christoph [0] https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-February/000853.html [1] https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-February/000843.html > -----Original Message----- > From: javadoc-dev <javadoc-dev-boun...@openjdk.java.net> On Behalf Of > Jonathan Gibbons > Sent: Donnerstag, 14. Februar 2019 00:03 > To: javadoc-dev <javadoc-dev@openjdk.java.net>; Joe Darcy > <joe.da...@oracle.com> > Subject: RFR" XXS testfix: 8218936 Test fails in Internet environment > > Please review a trivial test fix to replace the use of a tag which is > only valid in HTML 4 with one that is valid in HTML 5. > > The use of '<tt>' is replaced with '<b>'. > > The test only fails when run in an environment with access to the > Internet, and docs.oracle.com in particular. The test has started to > fail because HTML 4 is no longer supported, and the use of an invalid > tag causes the test to fail. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8218936 > > > $ hg diff > diff -r bdccafc038a2 > test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java > --- > a/test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java > Wed Feb 13 15:50:08 2019 -0500 > +++ > b/test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java > Wed Feb 13 15:00:04 2019 -0800 > @@ -88,14 +88,14 @@ > checkOutput("pkg/B.html", true, > "<div class=\"block\">A method with html tag the method " > + "<a href=\"" + url + > "java/lang/ClassLoader.html?is-external=true#getSystemClassLoader()\"" > - + " title=\"class or interface in java.lang\" > class=\"externalLink\"><code><tt>getSystemClassLoader()</tt>" > + + " title=\"class or interface in java.lang\" > class=\"externalLink\"><code><b>getSystemClassLoader()</b>" > + "</code></a> as the parent class loader.</div>", > "<div class=\"block\">is equivalent to invoking <code>" > + "<a > href=\"#createTempFile(java.lang.String,java.lang.String,java.io.File)\">" > + > "<code>createTempFile(prefix, suffix, null)</code></a></code > >.</div>", > "<a href=\"" + url + > "java/lang/String.html?is-external=true\" " > + "title=\"class or interface in java.lang\" > class=\"externalLink\">Link-Plain to String Class</a>", > - "<code><tt>getSystemClassLoader()</tt></code>", > + "<code><b>getSystemClassLoader()</b></code>", > "<code>createTempFile(prefix, suffix, null)</code>", > "<dd><a > href=\"http://www.ietf.org/rfc/rfc2279.txt\";><i>RFC 2279: UTF-8, > a\n" + > " transformation format of ISO 10646</i></a>, <br><a " + > diff -r bdccafc038a2 > test/langtools/jdk/javadoc/doclet/testLinkOption/pkg/B.java > --- a/test/langtools/jdk/javadoc/doclet/testLinkOption/pkg/B.java Wed > Feb 13 15:50:08 2019 -0500 > +++ b/test/langtools/jdk/javadoc/doclet/testLinkOption/pkg/B.java Wed > Feb 13 15:00:04 2019 -0800 > @@ -31,7 +31,7 @@ > public class B { > /** > * A method with html tag the method {@link > ClassLoader#getSystemClassLoader() > - * <tt>getSystemClassLoader()</tt>} as the parent class loader. > + * <b>getSystemClassLoader()</b>} as the parent class loader. > */ > public void method1() {} >
